Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: Do not run pre-release in forks #632

Merged
merged 1 commit into from
Oct 30, 2024
Merged

ci: Do not run pre-release in forks #632

merged 1 commit into from
Oct 30, 2024

Conversation

janbuchar
Copy link
Collaborator

@janbuchar janbuchar added t-tooling Issues with this label are in the ownership of the tooling team. adhoc Ad-hoc unplanned task added during the sprint. labels Oct 29, 2024
@janbuchar janbuchar requested review from B4nan and vdusek October 29, 2024 16:48
@github-actions github-actions bot added this to the 101st sprint - Tooling team milestone Oct 29, 2024
B4nan
B4nan approved these changes Oct 29, 2024
View reviewed changes
Copy link
Member

@B4nan B4nan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

how come the whole condition is a string btw?

@janbuchar
Copy link
Collaborator Author

how come the whole condition is a string btw?

YAML programming! I guess the quotes are not really necessary, but better safe than sorry.

vdusek
vdusek approved these changes Oct 29, 2024
View reviewed changes
Copy link
Collaborator

@vdusek vdusek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@B4nan
Copy link
Member

B4nan commented Oct 29, 2024 •
edited
Loading

I guess they are not, we have quite complex conditions elsewhere without them, e.g. https://github.com/apify/crawlee/blob/master/.github/workflows/test-ci.yml#L17

But I recall the parens were needed for this to work.

@janbuchar janbuchar merged commit bde0800 into master Oct 30, 2024
19 checks passed
@janbuchar janbuchar deleted the no-fork-prerelease branch October 30, 2024 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdusek vdusek vdusek approved these changes

@B4nan B4nan B4nan approved these changes

Assignees

@janbuchar janbuchar

Labels
adhoc Ad-hoc unplanned task added during the sprint. t-tooling Issues with this label are in the ownership of the tooling team.
Projects
None yet
Milestone
101st sprint - Tooling team
Development

Successfully merging this pull request may close these issues.
3 participants
@janbuchar @B4nan @vdusek