Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for SchemaMetaDataReviseEngine to test its public functions to improve unit test coverage. #29240

Conversation

HarshSawarkar
Copy link
Contributor

@HarshSawarkar HarshSawarkar commented Nov 30, 2023

Successfully added unit tests for SchemaMetaDataReviseEngine

Fixes #28534 .

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@tuichenchuxin
Copy link
Contributor

@HarshSawarkar Please fix ci AND remove useless empty line.

@HarshSawarkar HarshSawarkar deleted the 28534-Add-unit-tests-for-SchemaMetaDataReviseEngine branch January 24, 2024 09:06
@HarshSawarkar HarshSawarkar restored the 28534-Add-unit-tests-for-SchemaMetaDataReviseEngine branch January 24, 2024 09:07
@HarshSawarkar HarshSawarkar reopened this Jan 24, 2024
@HarshSawarkar
Copy link
Contributor Author

@HarshSawarkar Please fix ci AND remove useless empty line.

Updated

@terrymanu terrymanu merged commit e46c81c into apache:master Jan 25, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more unit tests for SchemaMetaDataReviseEngine
3 participants