Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for SchemaMetaDataReviseEngine #28534

Closed
tuichenchuxin opened this issue Sep 21, 2023 · 6 comments · Fixed by #29240
Closed

Add more unit tests for SchemaMetaDataReviseEngine #28534

tuichenchuxin opened this issue Sep 21, 2023 · 6 comments · Fixed by #29240

Comments

@tuichenchuxin
Copy link
Contributor

Hi community,

This issue is for #28487.

Aim

Add more unit tests for SchemaMetaDataReviseEngine to test its public functions to improve unit test coverage.

Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere

Basic Qualifications

  • Java
  • Maven
  • Junit
@mariacavalc
Copy link

Hey, can i take this one?

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Nov 17, 2023
@HarshSawarkar
Copy link
Contributor

hi @tuichenchuxin I would like to work on this issue.I have this one query regarding private revise() method.Do I need to write tests for this method also?Please see the attachment below.
image

@github-actions github-actions bot removed the stale label Nov 19, 2023
@tuichenchuxin
Copy link
Contributor Author

@HarshSawarkar No need to write test for private method

@HarshSawarkar
Copy link
Contributor

hey @tuichenchuxin i have raised a PR for this issue.Can you please review it . Here's the link #29240

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Dec 30, 2023
@terrymanu terrymanu added this to the 5.5.0 milestone Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment