Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added unit tests for WhereSegmentBinder to test its public functions … #29111

Conversation

HarshSawarkar
Copy link
Contributor

@HarshSawarkar HarshSawarkar commented Nov 21, 2023

…to improve unit test coverage.

Fixes #28513 .

Changes proposed in this pull request:

Added unit tests for WhereSegmentBinder to test its public functions to improve unit test coverage.

Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@strongduanmu
Copy link
Member

Hi @HarshSawarkar, can you try to fix ci error?

@HarshSawarkar HarshSawarkar deleted the 28513-Add-unit-tests-for-WhereSegmentBinder branch April 11, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add more unit tests for WhereSegmentBinder
2 participants