Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more unit tests for WhereSegmentBinder #28513

Closed
strongduanmu opened this issue Sep 21, 2023 · 5 comments · Fixed by #30852
Closed

Add more unit tests for WhereSegmentBinder #28513

strongduanmu opened this issue Sep 21, 2023 · 5 comments · Fixed by #30852

Comments

@strongduanmu
Copy link
Member

Hi community,

This issue is for #28487.

Aim

Add more unit tests for WhereSegmentBinder to test its public functions to improve unit test coverage.

Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere

Basic Qualifications

  • Java
  • Maven
  • Junit
@github-actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Oct 21, 2023
@grushad
Copy link

grushad commented Nov 10, 2023

hi @strongduanmu can i take this one up? although github-actions bot marked this as stale, this still needs to be worked on right?

@HarshSawarkar
Copy link
Contributor

Hi @strongduanmu I have created a PR for this issue.Can you please review it? Here's the link to my PR #29111

Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@HarshSawarkar
Copy link
Contributor

Hi @strongduanmu I have raised a new PR for this issue. Could you review it? Here's the link to it #30852

tuichenchuxin pushed a commit that referenced this issue Apr 12, 2024
* Added unit test for WhereSegmentBinder class methods

* Added unit test for WhereSegmentBinder class methods
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment