#28536 Add more unit tests for IndexReviseEngine #28834
Conversation
| @Test | ||
| void assertReviseIsPresentIsFalse() { | ||
| when(metaDataReviseEntry.getIndexReviser(any(), anyString())).thenReturn(Optional.empty()); | ||
|
|
There was a problem hiding this comment.
please remove empty line
There was a problem hiding this comment.
Done! Thanks :)
|
|
||
| Collection<IndexMetaData> indexMetaDataCollection = Collections.singletonList(new IndexMetaData("index")); | ||
| Collection<IndexMetaData> actual = indexReviseEngine.revise("tableName", indexMetaDataCollection); | ||
|
|
There was a problem hiding this comment.
please remove empty line
There was a problem hiding this comment.
Done! Thanks :)
| @Test | ||
| void assertReviseIsPresentIsTrue() { | ||
| IndexReviser<T> reviser = mock(IndexReviser.class); | ||
|
|
There was a problem hiding this comment.
please remove empty line
There was a problem hiding this comment.
Done! Thanks :)
| IndexReviser<T> reviser = mock(IndexReviser.class); | ||
|
|
||
| IndexMetaData indexMetaData = new IndexMetaData("index"); | ||
|
|
There was a problem hiding this comment.
please remove empty line
There was a problem hiding this comment.
Done! Thanks :)
| when(reviser.revise(anyString(), any(), any())).thenReturn(Optional.of(indexMetaData)); | ||
|
|
||
| Collection<IndexMetaData> indexMetaDataCollection = Arrays.asList(new IndexMetaData("index1"), new IndexMetaData("index2")); | ||
|
|
There was a problem hiding this comment.
please remove empty line
There was a problem hiding this comment.
Done! Thanks :)
| Collection<IndexMetaData> indexMetaDataCollection = Arrays.asList(new IndexMetaData("index1"), new IndexMetaData("index2")); | ||
|
|
||
| Collection<IndexMetaData> actual = indexReviseEngine.revise("tableName", indexMetaDataCollection); | ||
|
|
There was a problem hiding this comment.
please remove empty line
There was a problem hiding this comment.
Done! Thanks :)
| import static org.mockito.Mockito.doReturn; | ||
| import static org.mockito.Mockito.when; | ||
|
|
||
| public class IndexReviseEngineTest<T extends ShardingSphereRule> { |
There was a problem hiding this comment.
please remove public
There was a problem hiding this comment.
Done! Thanks :)
Fixes #28536.
Changes proposed in this pull request:
Before committing this PR, I'm sure that I have checked the following options:
./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.