Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add more unit tests for IndexReviseEngine #28536

Closed
tuichenchuxin opened this issue Sep 21, 2023 · 3 comments · Fixed by #28834
Closed

Add more unit tests for IndexReviseEngine #28536

tuichenchuxin opened this issue Sep 21, 2023 · 3 comments · Fixed by #28834
Assignees
@JessikaFujimura
Labels
good first issue in: test project: OSD2023 stale

Comments

@tuichenchuxin
Copy link
Contributor

Hi community,

This issue is for #28487.

Aim

Add more unit tests for IndexReviseEngine to test its public functions to improve unit test coverage.

Unit test coverage can be viewed at: https://app.codecov.io/gh/apache/shardingsphere

Basic Qualifications

  • Java
  • Maven
  • Junit
@JessikaFujimura
Copy link
Contributor

Hi, I’d like to do this issue.

Thank you!

JessikaFujimura added a commit to JessikaFujimura/shardingsphere that referenced this issue Oct 21, 2023
@JessikaFujimura
Add more unit tests for IndexReviseEngine (apache#28536)
43e29f3
JessikaFujimura added a commit to JessikaFujimura/shardingsphere that referenced this issue Oct 21, 2023
@JessikaFujimura
Add more validation (apache#28536)
a835345
@JessikaFujimura JessikaFujimura mentioned this issue Oct 21, 2023
Merged
6 tasks
@JessikaFujimura
Copy link
Contributor

Hi,
I open a PR #28834.
Let me know if any adjustment is necessary.

Thank you very much!

JessikaFujimura added a commit to JessikaFujimura/shardingsphere that referenced this issue Oct 23, 2023
@JessikaFujimura
fix codestyle: add space in the end (apache#28536)
081c239
@github-actions GitHub Actions
Copy link

There hasn't been any activity on this issue recently, and in order to prioritize active issues, it will be marked as stale.

@github-actions github-actions bot added the stale label Nov 21, 2023
JessikaFujimura added a commit to JessikaFujimura/shardingsphere that referenced this issue Mar 15, 2024
@JessikaFujimura
fix codestyle: remove the spaces inside the method (apache#28536)
7855250
tuichenchuxin pushed a commit that referenced this issue Mar 28, 2024
@JessikaFujimura
#28536 Add more unit tests for IndexReviseEngine (#28834)
355c8fa 
* Add more unit tests for IndexReviseEngine (#28536)

* Add more validation (#28536)

* fix codestyle: add space in the end (#28536)

* fix codestyle: remove the spaces inside the method (#28536)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JessikaFujimura JessikaFujimura

Labels
good first issue in: test project: OSD2023 stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

#28536 Add more unit tests for IndexReviseEngine JessikaFujimura/shardingsphere
2 participants
@JessikaFujimura @tuichenchuxin