Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates ElasticJob to 3.0.4 to block CVEs for SnakeYAML delivery #28805

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

linghengqian
Copy link
Member

@linghengqian linghengqian commented Oct 19, 2023

Fixes #24636.

Changes proposed in this pull request:


Before committing this PR, I'm sure that I have checked the following options:

  • My code follows the code of conduct of this project.
  • I have self-reviewed the commit code.
  • I have (or in comment I request) added corresponding labels for the pull request.
  • I have passed maven check locally : ./mvnw clean install -B -T1C -Dmaven.javadoc.skip -Dmaven.jacoco.skip -e.
  • I have made corresponding changes to the documentation.
  • I have added corresponding unit tests for my changes.

@linghengqian linghengqian added the type: dependencies Pull requests that update a dependency file label Oct 19, 2023
@linghengqian linghengqian added this to the 5.4.2 milestone Oct 19, 2023
@linghengqian linghengqian mentioned this pull request Oct 19, 2023
6 tasks
@linghengqian linghengqian marked this pull request as ready for review October 19, 2023 14:22
@xiohuchi
Copy link

不知道修复版本什么时候发布,有大佬知道怎么临时解决吗

@linghengqian
Copy link
Member Author

不知道修复版本什么时候发布,有大佬知道怎么临时解决吗

@xiohuchi

  • You can manually compile the project by following the steps below, and upload the corresponding products in the local Maven repository to your private repository. This uses SDKMAN!.
sdk install java 21.0.2-graalce
sdk use java 21.0.2-graalce

git clone [email protected]:apache/shardingsphere.git
cd ./shardingsphere/

./mvnw clean install -Prelease -T1C -DskipTests -Djacoco.skip=true -Dcheckstyle.skip=true -Drat.skip=true -Dmaven.javadoc.skip=true -B
  • I'm not the PMC for the project, so I can't make any subjective assumptions about when the next release will be. If you need a release sooner, you should start a discussion thread on the mailing list.

@1Yangc
Copy link

1Yangc commented Mar 16, 2024

   <dependency>
        <groupId>org.apache.shardingsphere</groupId>
        <artifactId>shardingsphere-jdbc</artifactId>
        <version>5.4.2-SNAPSHOT</version>
    </dependency>

Pay attention. Use shardingsphere-jdbc replace shardingsphere-jdbc-core

It's worked!
it bothered me for two days.
Thanks!

and how long can we use in new 5.4.2 release version?

@linghengqian
Copy link
Member Author

Pay attention. Use shardingsphere-jdbc replace shardingsphere-jdbc-core

and how long can we use in new 5.4.2 release version?

  • If you expect a faster release, you should leave a message in the mail thread at https://lists.apache.org/thread/0kwvkzclnhn312vjlcyyr02md995yfv9 . It seems that the several delays to the 5.5.0 milestone are due to the need to adjust the metadata structure.
  • As a committer, I personally only have non-binding release voting right. In any case, according to ASF regulations, the release process must be completed on the mailing list, which has nothing to do with github.com.

@1Yangc
Copy link

1Yangc commented Mar 16, 2024

Pay attention. Use shardingsphere-jdbc replace shardingsphere-jdbc-core

and how long can we use in new 5.4.2 release version?

  • If you expect a faster release, you should leave a message in the mail thread at https://lists.apache.org/thread/0kwvkzclnhn312vjlcyyr02md995yfv9 . It seems that the several delays to the 5.5.0 milestone are due to the need to adjust the metadata structure.
  • As a committer, I personally only have non-binding release voting right. In any case, according to ASF regulations, the release process must be completed on the mailing list, which has nothing to do with github.com.

Thanks!

@lizhongyue248
Copy link

   <dependency>
        <groupId>org.apache.shardingsphere</groupId>
        <artifactId>shardingsphere-jdbc</artifactId>
        <version>5.4.2-SNAPSHOT</version>
    </dependency>

Pay attention. Use shardingsphere-jdbc replace shardingsphere-jdbc-core

It's worked! it bothered me for two days. Thanks!

and how long can we use in new 5.4.2 release version?

Hello, did you manually compile the version 5.4.2-SNAPSHOT?

@linghengqian
Copy link
Member Author

@daipeizhe
Copy link

I found that even with ShardingSphere 5.4.1 and SnakeYaml 2.1, the startup was successful. Why?

@linghengqian
Copy link
Member Author

I found that even with ShardingSphere 5.4.1 and SnakeYaml 2.1, the startup was successful. Why?

  • There are many possible reasons. For example, you did not call the conflicting method of SnakeYAML. This may be because you only created the ShardingSphere data source through DistSQL of ShardingSphere Proxy or the Java API of ShardingSphere JDBC.

@daipeizhe
Copy link

I found that even with ShardingSphere 5.4.1 and SnakeYaml 2.1, the startup was successful. Why?

  • There are many possible reasons. For example, you did not call the conflicting method of SnakeYAML. This may be because you only created the ShardingSphere data source through DistSQL of ShardingSphere Proxy or the Java API of ShardingSphere JDBC.

If I manually reference SnakeYaml in the pom.xml file and specify a version above 2.x, the startup is fine; However, if you do not manually reference SnakeYaml, the SnakeYaml version of the project, although it is also 2.0, will still start error. In addition, I did configure ShardingSphere JDBC through the Java API.

@linghengqian
Copy link
Member Author

I found that even with ShardingSphere 5.4.1 and SnakeYaml 2.1, the startup was successful. Why?

  • There are many possible reasons. For example, you did not call the conflicting method of SnakeYAML. This may be because you only created the ShardingSphere data source through DistSQL of ShardingSphere Proxy or the Java API of ShardingSphere JDBC.

If I manually reference SnakeYaml in the pom.xml file and specify a version above 2.x, the startup is fine; However, if you do not manually reference SnakeYaml, the SnakeYaml version of the project, although it is also 2.0, will still start error. In addition, I did configure ShardingSphere JDBC through the Java API.

  • This doesn't really mean anything, as ShardingSphere JDBC 5.4.1 explicitly uses methods that were removed from SnakeYAML 2.0.

@daipeizhe
Copy link

I found that even with ShardingSphere 5.4.1 and SnakeYaml 2.1, the startup was successful. Why?

  • There are many possible reasons. For example, you did not call the conflicting method of SnakeYAML. This may be because you only created the ShardingSphere data source through DistSQL of ShardingSphere Proxy or the Java API of ShardingSphere JDBC.

If I manually reference SnakeYaml in the pom.xml file and specify a version above 2.x, the startup is fine; However, if you do not manually reference SnakeYaml, the SnakeYaml version of the project, although it is also 2.0, will still start error. In addition, I did configure ShardingSphere JDBC through the Java API.

  • This doesn't really mean anything, as ShardingSphere JDBC 5.4.1 explicitly uses methods that were removed from SnakeYAML 2.0.

You're right, I found out that the framework I was using overwrote the missing parameterless Representer class constructor.

Copy link
Member Author

@linghengqian linghengqian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: dependencies Pull requests that update a dependency file
Projects
None yet
6 participants