Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nightly CI fails on windows: lineBreak type mismatch #29429

Closed
RaigorJiang opened this issue Dec 18, 2023 · 0 comments · Fixed by #29430
Closed

Nightly CI fails on windows: lineBreak type mismatch #29429

RaigorJiang opened this issue Dec 18, 2023 · 0 comments · Fixed by #29430
Labels
type: bug
Milestone
5.5.0

Comments

@RaigorJiang
Copy link
Contributor

Details: https://github.com/apache/shardingsphere/actions/runs/7240149841/job/19722816797

image

After investigation, I found that it was caused by the working logic of snakeyaml.

1

In YamlEngine, we construct the Yaml object by passing representer, set dumperOptions in representer, and specify the type of lineBreak in dumperOptions.

image

2

However, in the construction flow, Yaml initializes a new dumperOptions instead of using the one provided in the representer, which causes the lineBreak type set in advance to be invalid.

image

3

And the new initialized dumperOptions, its lineBreak has the default value: LineBreak.UNIX

image

4

Relatedly, this issue can be traced to #28805

https://github.com/apache/shardingsphere/pull/28805/files#diff-806e38b8fb7f6f30a4e93659923cf23f84aaa77833f9eb4665063d8df2809f23
@RaigorJiang RaigorJiang added this to the 5.4.2 milestone Dec 18, 2023
RaigorJiang added a commit to RaigorJiang/shardingsphere that referenced this issue Dec 18, 2023
@RaigorJiang
Fixes apache#29429, fix yaml lineBreak on windows
426d8c1
@RaigorJiang RaigorJiang mentioned this issue Dec 18, 2023
Merged
totalo pushed a commit that referenced this issue Dec 18, 2023
@RaigorJiang
Fixes #29429, fix yaml lineBreak on windows (#29430)
69fed96 
* Fixes #29429, fix yaml lineBreak on windows

* Fix DQL E2E for PostgreSQL

* Comment case for pg_catalog.pg_stat_xact_all_tables

* Comment case for pg_catalog.pg_stat_xact_all_tables
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type: bug
Projects
None yet
Milestone
5.5.0
Development

Successfully merging a pull request may close this issue.

Fixes #29429, fix yaml lineBreak on windows RaigorJiang/shardingsphere
1 participant
@RaigorJiang