GH-45073: Update encryption test files to correct invalid repetition levels #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Have you changed the compression type? It seems that all files have at least 80% size reduction. |
No, they were using Snappy before and so I changed the writing code to keep using Snappy. I'm not sure why there's a size reduction. I'll see if I can figure out why. |
|
It looks like the size difference is caused by this change which stopped writing column metadata at the end of chunks: apache/arrow#43428 If I revert that commit then the file sizes match exactly. |
|
Thanks for the investigation! That makes sense. |
|
BTW, these files are used by parquet-java: https://github.com/apache/parquet-java/blob/master/parquet-hadoop/src/test/java/org/apache/parquet/hadoop/TestEncryptionOptions.java. We need to make sure that these tests won't fail after migrating to the new files. |
|
I tested updating parquet-java to reference my fork of parquet-testing with the new commit SHA and it looks like it worked fine: https://github.com/adamreeve/parquet-java/actions/runs/12407983545 Relevant lines from the log: |
mapleFU
approved these changes
Jan 2, 2025
There was a problem hiding this comment.
Would you mind change a "corrupt" file to the bad_file?
Also cc @ggershinsky
Just to confirm I've understood what you mean, do you mean add a file to the |
|
You're right, lets move forward |
|
OK thanks. I'm happy to add a |
I think so, we can do it separately |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See apache/arrow#45073. This fixes the encryption test files generated by Arrow C++ so that the repetition levels are correct. I tried to avoid changing other properties of these files like the compression and encodings used.
After applying the change to fix the repetition level (apache/arrow#45074), I generated the files by running the parquet-encryption-test tests with the following changes: