-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GH-45073: [C++][Parquet] Fix generation of repetition levels for encryption test data #45074
Conversation
The tests will fail until the test data is first fixed in apache/parquet-testing#65 and the submodule updated here. |
b326a78
to
dbde2b0
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
The integration build error looks like #45128, the error message is different but is the same as the current failure on the main branch:
|
dbde2b0
to
17dd3c2
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, thanks for this @adamreeve
After merging your PR, Conbench analyzed the 4 benchmarking runs that have been run so far on merge-commit a931aff. There were no benchmark performance regressions. 🎉 The full Conbench report has more details. It also includes information about 5 possible false positives for unstable benchmarks that are known to sometimes produce them. |
Rationale for this change
This makes the test data readable by other Parquet implementations that validate the repetition levels.
What changes are included in this PR?
Are these changes tested?
Yes, covered by existing tests.
Are there any user-facing changes?
No