refactor(layers/prometheus-client): provide builder APIs similar to PrometheusLayer
#5043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Xuanwo
reviewed
Aug 24, 2024
| } | ||
|
|
||
| /// Create a [`PrometheusClientLayerBuilder`]. | ||
| pub fn builder() -> PrometheusClientLayerBuilder { |
There was a problem hiding this comment.
Hi, we usually avoid providing too many structures at the layer level. How about just exposing the API at the PrometheusClientLayer level?
There was a problem hiding this comment.
The design of the prometheus library and the prometheus-client library is quite different.
For prometheus-client library, we have to accept the &mut Registry type to register our configured metrics.
If we want to provide some configurable methods similar to the PrometheusLayer, it seems that we have to construct the configuration through an additional type.
Do you have any other good ideas?
BTW, for prometheus library, we could expose the configurable APIs at the PrometheusLayer level.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No
Rationale for this change
provide similar APIs like
PrometheusLayerWhat changes are included in this PR?
Are there any user-facing changes?
PrometheusClientLayer::builder