refactor(layers/prometheus): use the same metrics as prometheus-client layer and provide similar APIs
#5042
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koushiro
commented
Aug 24, 2024
| } | ||
|
|
||
| /// [`PrometheusLayerBuilder`] is a config builder to build a [`PrometheusLayer`]. | ||
| pub struct PrometheusLayerBuilder { |
There was a problem hiding this comment.
I want to provide similar APIs for prometheus layer and prometheus-client layer,
however, the design of the prometheus library and the prometheus-client library is quite different, so I need to provide this builder pattern to construct a similar API.
prometheus-client layer: #5043
|
This PR makes think if we can reuse similar code in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
No
Rationale for this change
I would expect both layers (
PrometheusLayerandPrometheusClientLayer) to export the same metrics and provide similar APIs, with the only difference being the different prometheus libraries they use.What changes are included in this PR?
PrometheusClientLayerPrometheusLayerLayeredAccessimplAre there any user-facing changes?
PrometheusLayer::with_registry=>PrometheusLayer::newrequests_duration_seconds_bucketsbytes_total_bucketsenable_path_labelPrometheusLayer::builder