Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(layers/prometheus): use the same metrics as prometheus-client layer #5046

Closed
wants to merge 5 commits into from
Closed

refactor(layers/prometheus): use the same metrics as prometheus-client layer #5046

wants to merge 5 commits into from

Conversation

koushiro
Copy link
Member

Which issue does this PR close?

No

Rationale for this change

part of #5042

What changes are included in this PR?

  • unify the metrics, same as PrometheusClientLayer
  • refactor LayeredAccess impl

Are there any user-facing changes?

  • rename
    • PrometheusLayer::with_registry => PrometheusLayer::new
    • PrometheusLayer::bytes_total_buckets => PrometheusLayer::bytes_buckets
  • remove
    • #[derive(Default)] impl of PrometheusLayer

@koushiro koushiro requested a review from Xuanwo as a code owner August 24, 2024 15:22
@koushiro
Copy link
Member Author

@Xuanwo maybe you could review this PR first?

@koushiro koushiro closed this Aug 28, 2024
@koushiro koushiro deleted the refactor-prometheus-layer-2 branch September 3, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Awaiting requested review from Xuanwo Xuanwo is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@koushiro