Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(go-client): add generation thrift files of go-client #1917

Merged
merged 9 commits into from
Jun 20, 2024
Merged
Show file tree
Hide file tree
Changes from 7 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,11 @@ package-lock.json
# ============= #
go-client/bin
go-client/coverage.txt
go-client/idl/admin/
go-client/idl/cmd/
go-client/idl/radmin/
go-client/idl/replication/
go-client/idl/rrdb/
#go-client/idl/admin/
#go-client/idl/cmd/
#go-client/idl/radmin/
#go-client/idl/replication/
#go-client/idl/rrdb/
acelyc111 marked this conversation as resolved.
Show resolved Hide resolved

thirdparty/output/

Expand Down
9 changes: 6 additions & 3 deletions .licenserc.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -43,9 +43,12 @@ header:
# Special files for golang.
- '**/go.sum'
# TODO(wangdan): Generated files for go client, could generate dynamically?
acelyc111 marked this conversation as resolved.
Show resolved Hide resolved
- 'go-client/idl/base/GoUnusedProtection__.go'
- 'go-client/idl/base/dsn_err_string.go'
- 'go-client/idl/base/rocskdb_err_string.go'
- 'go-client/idl/admin/**'
- 'go-client/idl/base/**'
- 'go-client/idl/cmd/**'
- 'go-client/idl/radmin/**'
- 'go-client/idl/replication/**'
- 'go-client/idl/rrdb/**'
# Special files for nodejs.
- '**/.npmigonre'
# Special files for python.
Expand Down
2 changes: 1 addition & 1 deletion go-client/admin/client_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func TestAdmin_ListNodes(t *testing.T) {
for i, node := range nodes {
// Each node should be alive.
assert.Equal(t, admin.NodeStatus_NS_ALIVE, node.Status)
actualReplicaServerPorts[i] = node.Address.GetPort()
actualReplicaServerPorts[i] = node.GetNode().GetPort()
}

// Match elements without extra ordering.
Expand Down
6 changes: 6 additions & 0 deletions go-client/idl/admin/GoUnusedProtection__.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions go-client/idl/admin/backup-consts.go

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading