Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(go-client): add generation thrift files of go-client #1917

Merged
merged 9 commits into from
Jun 20, 2024
Merged

chore(go-client): add generation thrift files of go-client #1917

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
ed36c85
add generation thrift files of go-client
lengyuexuexuan Feb 22, 2024
6cbbe7d
Merge branch 'apache:master' into add_generation_thrift_files
lengyuexuexuan May 29, 2024
00b8ac5
Merge branch 'apache:master' into add_generation_thrift_files
lengyuexuexuan May 29, 2024
a15092b
add generated thrift files
May 29, 2024
3153a9d
remove go-client/idl/* in .gitignored file
May 29, 2024
d3cf8e4
fix client_test and licenserc
Jun 18, 2024
d1ba69d
fix licenserc
Jun 18, 2024
d35346a
Update .gitignore
acelyc111 Jun 20, 2024
1ea9598
Update .licenserc.yaml
acelyc111 Jun 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -342,11 +342,6 @@ package-lock.json
# ============= #
go-client/bin
go-client/coverage.txt
go-client/idl/admin/
go-client/idl/cmd/
go-client/idl/radmin/
go-client/idl/replication/
go-client/idl/rrdb/

thirdparty/output/

Expand Down
10 changes: 6 additions & 4 deletions .licenserc.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,10 +42,12 @@ header:
- '**/*.pdf'
# Special files for golang.
- '**/go.sum'
# TODO(wangdan): Generated files for go client, could generate dynamically?
- 'go-client/idl/base/GoUnusedProtection__.go'
- 'go-client/idl/base/dsn_err_string.go'
- 'go-client/idl/base/rocskdb_err_string.go'
- 'go-client/idl/admin/**'
- 'go-client/idl/base/**'
- 'go-client/idl/cmd/**'
- 'go-client/idl/radmin/**'
- 'go-client/idl/replication/**'
- 'go-client/idl/rrdb/**'
# Special files for nodejs.
- '**/.npmigonre'
# Special files for python.
Expand Down
2 changes: 1 addition & 1 deletion go-client/admin/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ func TestAdmin_ListNodes(t *testing.T) {
for i, node := range nodes {
// Each node should be alive.
assert.Equal(t, admin.NodeStatus_NS_ALIVE, node.Status)
actualReplicaServerPorts[i] = node.Address.GetPort()
actualReplicaServerPorts[i] = node.GetNode().GetPort()
}

// Match elements without extra ordering.
Expand Down
6 changes: 6 additions & 0 deletions go-client/idl/admin/GoUnusedProtection__.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

27 changes: 27 additions & 0 deletions go-client/idl/admin/backup-consts.go
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading