Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(collector): fix lint and build errors for go collector #1762

Merged
merged 4 commits into from
Dec 11, 2023
Merged

fix(collector): fix lint and build errors for go collector #1762

merged 4 commits into from
Dec 11, 2023

Conversation

empiredan
Copy link
Contributor

@empiredan empiredan commented Dec 11, 2023 •
edited
Loading

#1761

Fix lint and build errors for go collector, including:

  • upgrade go version to 1.17 to fix undefined time.Now().UnixMilli
  • fix format error ("File is not gofmt-ed with -s (gofmt)") of go source files by `gofmt -s -w
  • fix format string error ("Sprintf/Errorf format %s has arg addr of wrong type int (govet)") by a skipped index for range

@empiredan empiredan changed the title fix(go-collector): fix undefined time.Now().UnixMilli for go collector fix(collector): fix undefined time.Now().UnixMilli for go collector Dec 11, 2023
@empiredan empiredan changed the title fix(collector): fix undefined time.Now().UnixMilli for go collector fix(collector): fix lint and build errors for go collector Dec 11, 2023
@empiredan empiredan added the go Pull requests that update Go code label Dec 11, 2023
@empiredan empiredan merged commit d85837c into apache:master Dec 11, 2023
31 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GehaFearless GehaFearless GehaFearless approved these changes

@acelyc111 acelyc111 acelyc111 approved these changes

Assignees
No one assigned
Labels
collector github go Pull requests that update Go code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@empiredan @acelyc111 @GehaFearless