fix(collector): fix lint and build errors for go collector (#1762)

#1761

Fix lint and build errors for go collector, including:
- upgrade go version to 1.17 to fix undefined time.Now().UnixMilli
- fix format error ("File is not `gofmt`-ed with `-s` (gofmt)") of go source files by `gofmt -s -w
- fix format string error ("Sprintf/Errorf format %s has arg addr of wrong type int (govet)") by a skipped index for `range`

.github/workflows/lint_and_test_collector.yml

@@ -29,7 +29,8 @@ on:
       - ci-test # testing branch for github action
       - '*dev'
     paths:
-      - collector/**
+      - '.github/workflows/lint_and_test_collector.yml'
+      - 'collector/**'
 
   # for manually triggering workflow
   workflow_dispatch:
@@ -47,7 +48,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v4
         with:
-          go-version: 1.14
+          go-version: 1.17
           cache: false
       - name: Lint
         uses: golangci/golangci-lint-action@v3
@@ -66,7 +67,7 @@ jobs:
       - name: Set up Go
         uses: actions/setup-go@v2
         with:
-          go-version: 1.14
+          go-version: 1.17
       - name: Build
         working-directory: ./collector
         run: make

collector/avail/detector.go

@@ -91,9 +91,9 @@ type pegasusDetector struct {
 	detectTableName string
 	detectInterval  time.Duration
 	// timeout of a single detect.
-	detectTimeout	time.Duration
+	detectTimeout time.Duration
 	// partition count.
-	partitionCount	int
+	partitionCount int
 }
 
 func (d *pegasusDetector) Start(tom *tomb.Tomb) error {

collector/metrics/metric_collector.go

@@ -102,7 +102,7 @@ func (collector *Collector) Start(tom *tomb.Tomb) error {
 func getReplicaAddrs() ([]string, error) {
 	addrs := viper.GetStringSlice("meta_servers")
 	var rserverAddrs []string
-	for addr := range addrs {
+	for _, addr := range addrs {
 		url := fmt.Sprintf("http://%s/meta/nodes", addr)
 		resp, err := http.Get(url)
 		if err == nil && resp.StatusCode != http.StatusOK {
@@ -291,29 +291,29 @@ func updateClusterLevelTableMetrics(metricsByTableID map[string]Metrics) {
 func updateMetric(metric Metric, endpoint string, level string, title string) {
 	role := RoleByDataSource[DataSource]
 	switch metric.mtype {
-		case "Counter":
-			if counter, ok := CounterMetricsMap[metric.name]; ok {
-				counter.With(
-					prometheus.Labels{"endpoint": endpoint,
-						"role": role, "level": level,
-						"title": title}).Add(float64(metric.value))
-			} else {
-				log.Warnf("Unknown metric name %s", metric.name)
-			}
-		case "Gauge":
-			if gauge, ok := GaugeMetricsMap[metric.name]; ok {
-				gauge.With(
-					prometheus.Labels{"endpoint": endpoint,
-						"role": role, "level": level,
-						"title": title}).Set(float64(metric.value))
-			} else {
-				log.Warnf("Unknown metric name %s", metric.name)
-			}
-		case "Percentile":
-			log.Warnf("Todo metric type %s", metric.mtype)
-		case "Histogram":
-		default:
-			log.Warnf("Unsupport metric type %s", metric.mtype)
+	case "Counter":
+		if counter, ok := CounterMetricsMap[metric.name]; ok {
+			counter.With(
+				prometheus.Labels{"endpoint": endpoint,
+					"role": role, "level": level,
+					"title": title}).Add(float64(metric.value))
+		} else {
+			log.Warnf("Unknown metric name %s", metric.name)
+		}
+	case "Gauge":
+		if gauge, ok := GaugeMetricsMap[metric.name]; ok {
+			gauge.With(
+				prometheus.Labels{"endpoint": endpoint,
+					"role": role, "level": level,
+					"title": title}).Set(float64(metric.value))
+		} else {
+			log.Warnf("Unknown metric name %s", metric.name)
+		}
+	case "Percentile":
+		log.Warnf("Todo metric type %s", metric.mtype)
+	case "Histogram":
+	default:
+		log.Warnf("Unsupport metric type %s", metric.mtype)
 	}
 }