Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Web console: use stages, counters, and warnings from the new detailed status API #16809

Merged
merged 5 commits into from
Aug 1, 2024
Merged

Web console: use stages, counters, and warnings from the new detailed status API #16809

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
bf1dec9
stages and counters can be seen on the status reponse
vogievetsky Jul 26, 2024
c6b6007
warnings are exposed also
vogievetsky Jul 26, 2024
34a2a98
mark as msq when attached
vogievetsky Jul 27, 2024
e0b01b2
update snapshots
vogievetsky Jul 27, 2024
af2057e
download CSV/TSV null as empty cell
vogievetsky Jul 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
674 changes: 662 additions & 12 deletions web-console/src/druid-models/async-query/async-query.mock.ts
View file
Open in desktop

Large diffs are not rendered by default.

5 changes: 5 additions & 0 deletions web-console/src/druid-models/async-query/async-query.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,6 +17,8 @@
*/

import type { ErrorResponse } from '../../utils';
import type { Counters, StageDefinition } from '../stages/stages';
import type { MsqTaskErrorReport } from '../task/task';

export type AsyncState = 'ACCEPTED' | 'RUNNING' | 'SUCCESS' | 'FAILED';

Expand All @@ -37,5 +39,8 @@ export interface AsyncStatusResponse {
sizeInBytes: number;
}[];
};
stages?: StageDefinition[];
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it matter that there seem to be stuff missing from StageDefinition that are present in MSQStagesReport on the java side? it looks like shuffle and output, https://github.com/apache/druid/blob/master/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/report/MSQStagesReport.java#L146

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I actually added it as part of this PR: https://github.com/apache/druid/pull/16809/files#diff-33ae14291c451661ad8a83ecbca49afc6be1d01a5b882e42725bca19ac22c02fR77

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hah, oops, idk how i missed that 🙃

counters?: Counters;
errorDetails?: ErrorResponse;
warnings?: MsqTaskErrorReport[];
}
Loading
Loading