Web console: use stages, counters, and warnings from the new detailed status API #16809
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clintropolis
approved these changes
Aug 1, 2024
| @@ -37,5 +39,8 @@ export interface AsyncStatusResponse { | |||
| sizeInBytes: number; | |||
| }[]; | |||
| }; | |||
| stages?: StageDefinition[]; | |||
There was a problem hiding this comment.
does it matter that there seem to be stuff missing from StageDefinition that are present in MSQStagesReport on the java side? it looks like shuffle and output, https://github.com/apache/druid/blob/master/extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/indexing/report/MSQStagesReport.java#L146
There was a problem hiding this comment.
I actually added it as part of this PR: https://github.com/apache/druid/pull/16809/files#diff-33ae14291c451661ad8a83ecbca49afc6be1d01a5b882e42725bca19ac22c02fR77
There was a problem hiding this comment.
hah, oops, idk how i missed that 🙃
sreemanamala
pushed a commit
to sreemanamala/druid
that referenced
this pull request
Aug 6, 2024
… status API (apache#16809) * stages and counters can be seen on the status reponse * warnings are exposed also * mark as msq when attached * update snapshots * download CSV/TSV null as empty cell
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Console updates following API updates done in #16808. Merge this after the API PR is merged. Can be used to test API PR.
Also:
nullis written out to CSV