Transactional replace should only consider supervisors with appending locks #15220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -434,6 +438,69 @@ public void testCreateSuspendResumeAndStopSupervisor() | |||
| Assert.assertTrue(manager.getSupervisorIds().isEmpty()); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGetActiveSupervisorIdForDatasourceWithAppendLock() | |||
There was a problem hiding this comment.
there is a lot of fine-grained mocking here that makes the test aware of each and every call being made in the implementation. We should refactor the code so we can avoid such mocking.
abhishekagarwal87
approved these changes
Oct 22, 2023
LakshSingla
pushed a commit
to LakshSingla/druid
that referenced
this pull request
Oct 23, 2023
…al replace (apache#15220) A SegmentTransactionReplaceAction must only update the mapping of tasks with append locks that are running concurrently. To ensure this, we return the supervisor id only if it has the taskLockType as APPEND in its context.
LakshSingla
added a commit
that referenced
this pull request
Oct 23, 2023
…al replace (#15220) (#15229) A SegmentTransactionReplaceAction must only update the mapping of tasks with append locks that are running concurrently. To ensure this, we return the supervisor id only if it has the taskLockType as APPEND in its context. Co-authored-by: AmatyaAvadhanula <[email protected]>
10 tasks
CaseyPan
pushed a commit
to CaseyPan/druid
that referenced
this pull request
Nov 17, 2023
…al replace (apache#15220) A SegmentTransactionReplaceAction must only update the mapping of tasks with append locks that are running concurrently. To ensure this, we return the supervisor id only if it has the taskLockType as APPEND in its context.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A SegmentTransactionReplaceAction must only update the mapping of tasks with append locks that are running concurrently. To ensure this, we return the supervisor id only if it has the taskLockType as APPEND in its context.
This PR has: