Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Backport] Transactional replace should only consider supervisors with appending locks #15229

Merged
merged 1 commit into from
Oct 23, 2023
Merged

[Backport] Transactional replace should only consider supervisors with appending locks #15229

merged 1 commit into from
Oct 23, 2023

Conversation

LakshSingla
Copy link
Contributor

Backport of #15220 to 28.0.0.

@AmatyaAvadhanula @LakshSingla
Consider only supervisors with append lock for concurrent transaction…
364e524 
…al replace (apache#15220)

A SegmentTransactionReplaceAction must only update the mapping of tasks with append locks that are running concurrently. To ensure this, we return the supervisor id only if it has the taskLockType as APPEND in its context.
AmatyaAvadhanula
AmatyaAvadhanula approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the backport @LakshSingla!

@LakshSingla LakshSingla merged commit dda8410 into apache:28.0.0 Oct 23, 2023
77 checks passed
@LakshSingla LakshSingla added this to the 28.0 milestone Oct 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmatyaAvadhanula AmatyaAvadhanula AmatyaAvadhanula approved these changes

Assignees
No one assigned
Labels
Area - Ingestion Backport
Projects
None yet
Milestone
28.0
Development

Successfully merging this pull request may close these issues.
2 participants
@LakshSingla @AmatyaAvadhanula