Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Proper default for taskLockType in streaming ingestion #15213

Merged
merged 2 commits into from
Oct 19, 2023

Conversation

lorem--ipsum
Copy link
Contributor

Accounts for the fact that we're looking at a streaming spec or a batch spec to set the taskLockType.

Copy link
Contributor

@AmatyaAvadhanula AmatyaAvadhanula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for the quick fix @lorem--ipsum!

@AmatyaAvadhanula AmatyaAvadhanula added this to the 28.0 milestone Oct 19, 2023
@AmatyaAvadhanula AmatyaAvadhanula merged commit 5752a1a into apache:master Oct 19, 2023
11 checks passed
AmatyaAvadhanula pushed a commit to AmatyaAvadhanula/druid that referenced this pull request Oct 19, 2023
* Proper value for taskLockType in streaming ingestion with concurrent compaction
LakshSingla pushed a commit that referenced this pull request Oct 19, 2023
* Proper value for taskLockType in streaming ingestion with concurrent compaction

Co-authored-by: Sébastien <[email protected]>
CaseyPan pushed a commit to CaseyPan/druid that referenced this pull request Nov 17, 2023
* Proper value for taskLockType in streaming ingestion with concurrent compaction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants