Proper default for taskLockType in streaming ingestion (apache#15213)

* Proper value for taskLockType in streaming ingestion with concurrent compaction
CaseyPan · Nov 17, 2023 · d7f7f09 · d7f7f09
1 parent 4824056
commit d7f7f09
Showing 1 changed file with 18 additions and 2 deletions.
diff --git a/web-console/src/views/load-data-view/load-data-view.tsx b/web-console/src/views/load-data-view/load-data-view.tsx
@@ -3178,8 +3178,24 @@ export class LoadDataView extends React.PureComponent<LoadDataViewProps, LoadDat
                   appendToExisting ? 'append' : 'replace'
                 } tasks (experimental)`,
                 defaultValue: undefined,
-                valueAdjustment: v => (v ? (appendToExisting ? 'APPEND' : 'REPLACE') : undefined),
-                adjustValue: v => v === (appendToExisting ? 'APPEND' : 'REPLACE'),
+                valueAdjustment: v => {
+                  if (!v) return undefined;
+
+                  if (isStreamingSpec(spec)) {
+                    return 'APPEND';
+                  } else {
+                    return appendToExisting ? 'APPEND' : 'REPLACE';
+                  }
+                },
+                adjustValue: v => {
+                  if (v === undefined) return false;
+
+                  if (isStreamingSpec(spec)) {
+                    return v === 'APPEND';
+                  }
+
+                  return v === (appendToExisting ? 'APPEND' : 'REPLACE');
+                },
                 info: <p>Allows or forbids concurrent tasks.</p>,
               },
             ]}