Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix verify_release_candidate.sh for new arrow subcrates #2752

Merged
merged 1 commit into from
Sep 16, 2022
Merged

Fix verify_release_candidate.sh for new arrow subcrates #2752

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions dev/release/verify-release-candidate.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -116,21 +116,16 @@ test_source_distribution() {
export ARROW_TEST_DATA=$PWD/arrow-testing-data/data
export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data

# use local modules because we don't publish modules to crates.io yet
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These regex don't actually match anything and I found the script passes for me without this code

sed \
-i.bak \
-E \
-e 's/^arrow = "([^"]*)"/arrow = { version = "\1", path = "..\/arrow" }/g' \
-e 's/^parquet = "([^"]*)"/parquet = { version = "\1", path = "..\/parquet" }/g' \
*/Cargo.toml

(cd arrow && cargo build && cargo test)
(cd arrow-flight && cargo build && cargo test)
(cd parquet && cargo build && cargo test)
(cd parquet_derive && cargo build && cargo test)

# verify that the crates can be published to crates.io
pushd arrow
# verify that the leaf crates can be published to crates.io
# we can't verify crates that depend on others
# (because the others haven't yet been published to crates.io)

pushd arrow-buffer
cargo publish --dry-run
popd
Comment on lines +128 to 130
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems due to rust-lang/cargo#1565

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only verifying on leaf crates seems not perfect, but it appears that no better way to fix it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, it would be great to verify all the crates...


Expand Down