Fix verify_release_candidate.sh for new arrow subcrates
#2752
Conversation
| @@ -116,21 +116,16 @@ test_source_distribution() { | |||
| export ARROW_TEST_DATA=$PWD/arrow-testing-data/data | |||
| export PARQUET_TEST_DATA=$PWD/parquet-testing-data/data | |||
|
|
|||
| # use local modules because we don't publish modules to crates.io yet | |||
There was a problem hiding this comment.
These regex don't actually match anything and I found the script passes for me without this code
| pushd arrow-buffer | ||
| cargo publish --dry-run | ||
| popd |
There was a problem hiding this comment.
Seems due to rust-lang/cargo#1565
There was a problem hiding this comment.
Only verifying on leaf crates seems not perfect, but it appears that no better way to fix it.
There was a problem hiding this comment.
yeah, it would be great to verify all the crates...
|
@alamb Really thanks! This works! |
|
Benchmark runs are scheduled for baseline = 5a55406 and contender = ca00b67. ca00b67 is a master commit associated with this PR. Results will be available as each benchmark for each run completes. |
Which issue does this PR close?
Fixes: #2751
re #2665
Rationale for this change
#2693 added a new
arrow-buffercrate on which arrow depends which is good 🎉⚖️ but it means we can no longer run
cargo publish --dry-runforarrowas it it now depends on an as-yet-unpublushed crate (arrow-buffer)What changes are included in this PR?
cargo publish --dry-runfor the leaf cratearrow-bufferrather thanarrowsedcommand)Are there any user-facing changes?