FIX: Object oriented name update #5595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When a mesh operation wasn't defined in desktop, invkoking the name property thew an error in AEDT.
Fix issue because GetChildObject() method does not behave consistently among AEDT solvers.
Fix issue because GetChildObject() method does not behave consistently among AEDT solvers.
For more information, see https://pre-commit.ci
Implemented code review suggestions. Co-authored-by: Sébastien Morais <[email protected]>
Simplify syntax
…IX/Mesh-Operations-5568 # Conflicts: # src/ansys/aedt/core/application/design.py
For more information, see https://pre-commit.ci
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
This was referenced Dec 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5595 +/- ##
==========================================
+ Coverage 81.37% 85.27% +3.89%
==========================================
Files 152 152
Lines 60904 60987 +83
==========================================
+ Hits 49562 52004 +2442
+ Misses 11342 8983 -2359 |
# Conflicts: # src/ansys/aedt/core/modules/mesh.py
Closed
7 tasks
maxcapodi78
previously approved these changes
Dec 19, 2024
…yaedt into fix/Mesh-Operations-5568
|
All tests are passing, but before merging, I am checking if the examples are passing |
maxcapodi78
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Please provide a brief description of the changes made in this pull request.
Issue linked
Close #5568
Checklist