Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix active design selection behavior for Emit designs #4587

Merged
merged 3 commits into from
Apr 26, 2024
Merged

Fix active design selection behavior for Emit designs #4587

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
075f1b5
Fix active design selection behavior for Emit designs
myoung301 Apr 24, 2024
83d3e9d
Remove unused import in emit.py
myoung301 Apr 24, 2024
f89c709
Use a new EMIT design for unit tests that require it
myoung301 Apr 26, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions _unittest_solvers/test_26_emit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import pytest

from pyaedt import Emit
from pyaedt import generate_unique_project_name
from pyaedt.emit_core.emit_constants import EmiCategoryFilter
from pyaedt.emit_core.emit_constants import InterfererType
from pyaedt.emit_core.emit_constants import ResultType
Expand Down Expand Up @@ -373,7 +374,7 @@ def test_07_antenna_component(self, add_app):
reason="Skipped on versions earlier than 2023.2",
)
def test_08_revision_generation(self, add_app):
self.aedtapp = add_app(application=Emit)
self.aedtapp = add_app(application=Emit, project_name=generate_unique_project_name())
assert len(self.aedtapp.results.revisions) == 0
# place components and generate the appropriate number of revisions
rad1 = self.aedtapp.modeler.components.create_component("UE - Handheld")
Expand Down Expand Up @@ -443,7 +444,7 @@ def test_08_revision_generation(self, add_app):
reason="Skipped on versions earlier than 2023.2",
)
def test_09_manual_revision_access_test_getters(self, add_app):
self.aedtapp = add_app(application=Emit)
self.aedtapp = add_app(application=Emit, project_name=generate_unique_project_name())
rad1 = self.aedtapp.modeler.components.create_component("UE - Handheld")
ant1 = self.aedtapp.modeler.components.create_component("Antenna")
rad2 = self.aedtapp.modeler.components.create_component("Bluetooth")
Expand Down Expand Up @@ -512,7 +513,7 @@ def test_09_manual_revision_access_test_getters(self, add_app):
reason="Skipped on versions earlier than 2023.2",
)
def test_10_radio_band_getters(self, add_app):
self.aedtapp = add_app(application=Emit)
self.aedtapp = add_app(application=Emit, project_name=generate_unique_project_name())
rad1, ant1 = self.aedtapp.modeler.components.create_radio_antenna("New Radio")
rad2, ant2 = self.aedtapp.modeler.components.create_radio_antenna("Bluetooth Low Energy (LE)")
rad3, ant3 = self.aedtapp.modeler.components.create_radio_antenna("WiFi - 802.11-2012")
Expand Down Expand Up @@ -729,7 +730,7 @@ def test_14_version(self, add_app):
reason="Skipped on versions earlier than 2023.2",
)
def test_15_basic_run(self, add_app):
self.aedtapp = add_app(application=Emit)
self.aedtapp = add_app(application=Emit, project_name=generate_unique_project_name())
assert len(self.aedtapp.results.revisions) == 0
# place components and generate the appropriate number of revisions
rad1 = self.aedtapp.modeler.components.create_component("UE - Handheld")
Expand Down Expand Up @@ -811,7 +812,7 @@ def test_15_basic_run(self, add_app):
reason="Skipped on versions earlier than 2024.1",
)
def test_16_optimal_n_to_1_feature(self, add_app):
self.aedtapp = add_app(application=Emit)
self.aedtapp = add_app(application=Emit, project_name=generate_unique_project_name())
# place components and generate the appropriate number of revisions
rad1 = self.aedtapp.modeler.components.create_component("Bluetooth")
ant1 = self.aedtapp.modeler.components.create_component("Antenna")
Expand Down Expand Up @@ -867,7 +868,7 @@ def test_16_optimal_n_to_1_feature(self, add_app):
reason="Skipped on versions earlier than 2023.2",
)
def test_17_availability_1_to_1(self, add_app):
self.aedtapp = add_app(application=Emit)
self.aedtapp = add_app(application=Emit, project_name=generate_unique_project_name())
# place components and generate the appropriate number of revisions
rad1 = self.aedtapp.modeler.components.create_component("MD400C")
ant1 = self.aedtapp.modeler.components.create_component("Antenna")
Expand Down
3 changes: 0 additions & 3 deletions pyaedt/emit.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
import warnings

from pyaedt import emit_core
from pyaedt import generate_unique_project_name
from pyaedt.application.Design import Design
from pyaedt.emit_core.Couplings import CouplingsEmit
from pyaedt.emit_core.emit_constants import EMIT_VALID_UNITS
Expand Down Expand Up @@ -114,8 +113,6 @@ def __init__(
port=0,
aedt_process_id=None,
):
if projectname is None:
projectname = generate_unique_project_name()
self.__emit_api_enabled = False
self.results = None
"""Constructor for the ``FieldAnalysisEmit`` class"""
Expand Down
Loading