Fix active design selection behavior for Emit designs #4587
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If the project and design names are not specified, the active project and active design are supposed to be used. However, a new project is always being created when the Emit() object is created.
|
Thanks for opening a Pull Request. If you want to perform a review write a comment saying: @ansys-reviewer-bot review |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4587 +/- ##
==========================================
+ Coverage 81.52% 81.53% +0.01%
==========================================
Files 110 110
Lines 53765 53772 +7
==========================================
+ Hits 43831 43843 +12
+ Misses 9934 9929 -5 |
jsalant22
previously approved these changes
Apr 24, 2024
|
@myoung301 Thanks for the contribution ! Could you also update the tests such that your modification passes our CI ? |
SMoraisAnsys
approved these changes
Apr 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the project and design names are not specified, the active project and active design are supposed to be used. However, a new project is always being created when the Emit() object is created.