-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: manual biometrics and background lock #201
Merged
Merged
Changes from 2 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
99fdadd
feat: button for faceid
janrtvld dc36d51
fix: show empty when no biometrics
janrtvld f4c8d89
fix: default floating sheet to padding value
janrtvld 78cb300
chore: icon type
janrtvld d02acd9
chore: better haptic
janrtvld 9747a2f
allow issuance deeplinks
TimoGlastra 37b6016
chore: types
janrtvld e357675
chore: state
janrtvld 5eb7b9d
chore: unused import
janrtvld File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
import type { PropsWithChildren } from 'react' | ||
|
||
import { useSecureUnlock } from '@package/secure-store/secure-wallet-key/SecureUnlockProvider' | ||
import { useEffect, useRef } from 'react' | ||
import React from 'react' | ||
import { AppState, type AppStateStatus } from 'react-native' | ||
|
||
const BACKGROUND_TIME_THRESHOLD = 3000 // FIXME | ||
|
||
export function BackgroundLockProvider({ children }: PropsWithChildren) { | ||
const secureUnlock = useSecureUnlock() | ||
const backgroundTimeRef = useRef<Date | null>(null) | ||
|
||
useEffect(() => { | ||
const handleAppStateChange = (nextAppState: AppStateStatus) => { | ||
if (nextAppState === 'background' || nextAppState === 'inactive') { | ||
backgroundTimeRef.current = new Date() | ||
} else if (nextAppState === 'active') { | ||
if (backgroundTimeRef.current) { | ||
const timeInBackground = new Date().getTime() - backgroundTimeRef.current.getTime() | ||
janrtvld marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
||
if (timeInBackground > BACKGROUND_TIME_THRESHOLD && secureUnlock.state === 'unlocked') { | ||
janrtvld marked this conversation as resolved.
Show resolved
Hide resolved
|
||
console.log('App was in background for more than 30 seconds, locking') | ||
secureUnlock.lock() | ||
} | ||
backgroundTimeRef.current = null | ||
} | ||
} | ||
} | ||
|
||
const subscription = AppState.addEventListener('change', handleAppStateChange) | ||
|
||
return () => { | ||
subscription.remove() | ||
} | ||
}, [secureUnlock]) | ||
|
||
return <>{children}</> | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This doesn't seem correct. What are you trying to do?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, it prompts me for me biometrics right away, and if you cancel it prompts again until you reach 3.
Now it prompts once, if it fails or gets cancelled it stops, and you can prompt it again by pressing the biometrics button on the pinpad.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm okay. I see. We should still pass
secureUnlock.state
right?