feat: manual biometrics and background lock #201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jan <[email protected]>
TimoGlastra
reviewed
Nov 4, 2024
Comment on lines
33
to
38
| // biome-ignore lint/correctness/useExhaustiveDependencies: canTryUnlockingUsingBiometrics not needed | ||
| useEffect(() => { | ||
| if (secureUnlock.state === 'locked' && secureUnlock.canTryUnlockingUsingBiometrics) { | ||
| secureUnlock.tryUnlockingUsingBiometrics() | ||
| } | ||
| }, [secureUnlock]) | ||
| }, []) |
There was a problem hiding this comment.
This doesn't seem correct. What are you trying to do?
There was a problem hiding this comment.
Currently, it prompts me for me biometrics right away, and if you cancel it prompts again until you reach 3.
Now it prompts once, if it fails or gets cancelled it stops, and you can prompt it again by pressing the biometrics button on the pinpad.
There was a problem hiding this comment.
Hmm okay. I see. We should still pass secureUnlock.state right?
TimoGlastra
reviewed
Nov 4, 2024
TimoGlastra
reviewed
Nov 4, 2024
TimoGlastra
reviewed
Nov 4, 2024
TimoGlastra
approved these changes
Nov 4, 2024
Signed-off-by: Timo Glastra <[email protected]>
|
The biometric button didn't seem to work for me btw? Not sure why but pressing it didn't do anything |
|
Hmm ill keep an eye on it |
|
Yeah it really doesn't work on my end. The button does nothing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.