chore: fix false positive in detecting that yardstick changed #388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, if "git diff" included the yardstick dependency declaration in one of the context/unchanged lines, configure.py would request running the quality gate on every provider. Fix this false positive by only considering lines with changes in them in the output. Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
added
the
run-pr-quality-gate
kzantow
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if "git diff" included the yardstick dependency declaration in one of the context/unchanged lines, configure.py would request running the quality gate on every provider. Fix this false positive by only considering lines with changes in them in the output.
Basically, this check could false positive, as evident in #387 trying to run all the providers even though it doesn't change anything that should necessitate that.