chore: fix false positive in detecting that yardstick changed (#388)

Previously, if "git diff" included the yardstick dependency declaration in one of the context/unchanged lines, configure.py would request running the quality gate on every provider. Fix this false positive by only considering lines with changes in them in the output. Signed-off-by: Will Murphy <[email protected]>
anchore · Nov 7, 2023 · 3b3fc2a · 3b3fc2a
1 parent 13a1853
commit 3b3fc2a
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/tests/quality/configure.py b/tests/quality/configure.py
@@ -338,6 +338,10 @@ def yardstick_version_changed():
     # get list of files changed with git diff
     changes = subprocess.check_output(["git", "diff", base_ref]).decode("utf-8").splitlines()
     for line in changes:
+        if not line.strip().startswith(("-", "+")):
+            # this line is in the output of `git diff`, but is just context, not a change
+            continue
+
         if 'git = "https://github.com/anchore/yardstick"' in line:
             return True