Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow all bare try-except clauses #310

Closed
wagoodman opened this issue Sep 29, 2023 · 1 comment
Closed

Disallow all bare try-except clauses #310

wagoodman opened this issue Sep 29, 2023 · 1 comment
Assignees
@willmurphyscode
Labels
bug Something isn't working tech-debt

Comments

@wagoodman
Copy link
Contributor

wagoodman commented Sep 29, 2023 •
edited by willmurphyscode
Loading

Today we have several noqa: E722 statements as well as ignoring blank noqa statements (here and here). We should:

  • not allow bare noqa statements, as this can hide a lot of issues
  • not allow any E722 exceptions, as this is a popular antipattern in this codebase and has lead to production regressions

Additionally, all except: blocks should log the exception and some useful context, to make feed failures easier to diagnose from logs.
@wagoodman wagoodman added bug Something isn't working tech-debt labels Sep 29, 2023
@willmurphyscode willmurphyscode self-assigned this Sep 29, 2023
This was referenced Oct 20, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
This was referenced Oct 27, 2023
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
Merged
@willmurphyscode
Copy link
Contributor

All the refactors we planned under this issue to make it easier / safer to work in Vunnel are implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@willmurphyscode willmurphyscode

Labels
bug Something isn't working tech-debt
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@wagoodman @willmurphyscode