chore: remove file scoped noqa for ubuntu parser #372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Accept some auto-fixes, and suppress lints that would require more in-depth changes. Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
added
the
run-pr-quality-gate
willmurphyscode
commented
Oct 27, 2023
| @@ -804,10 +811,9 @@ def _reprocess_merged_cve(self, cve_id: str, cve_rel_path: str): | |||
| if merged_patches or to_be_merged_map: | |||
| self.logger.debug("found unresolved patches in previously merged state, could be a new distro") | |||
| # Process revision history for eol-ed packages that need to be merged | |||
| saved_state.priority if not None else "Unknown" | |||
There was a problem hiding this comment.
It might be worth trying to figure out what this line was meant to do (ruff flagged it as an expression whose result is never assigned). Does anyone have some more context here?
wagoodman
approved these changes
Oct 27, 2023
…le-noqa-ubuntu-parser
willmurphyscode
removed
the
run-pr-quality-gate
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accept some auto-fixes, and suppress lints that would require more in-depth changes.
Note: There is a full line deletion in here; the line was an expression that was never assigned. But if someone has context on what was meant to be there, please let me know!
See #310