refactor: introduce http get utility; use it in mariner provider

[willmurphyscode]

Create a wrapper for requests.get at utils/http.py. The wrapper should always log the URL on failures, and should handle retries. Unit test the wrapper, and use it in the mariner provider.

Follow up PRs will introduce the wrapper into other providers.

See #310

[wagoodman]

There might be an opportunity for refactoring downloading files from a single util function that we can reuse everywhere. That way logging is done the same way, at the same level, can be stubbed out the same way, etc.

based on an offline conversation, this seems like the right time to invest in the common util function to get default retry, logging, and raise behavior for the common requests.get()

[wagoodman]

nit/suggestion: since this will show up a lot, the smaller the better

Suggested change

	logger.debug(f"attempting get request on {url}")
	logger.debug(f"http GET {url}")

[wagoodman]

why not this?

Suggested change

	if isinstance(last_exception, BaseException):
	logger.error(f"last retry of GET {url} failed with {last_exception}")
	raise last_exception
	raise Exception("unreachable")
	logger.error(f"last retry of GET {url} failed with {last_exception}")
	raise last_exception

[willmurphyscode]

I had that at first, but the type of last_exception is Exception | None, and the static analysis tools can't tell that it's guaranteed not to be None by the time that line is reached, so I have to check that last_exception isn't None before returning it, or static analysis fails. I can change to if last_exception instead of the isinstance, but I haven't figured out how to not need this at all.

[wagoodman]

This could be something like this:

@pytest.fixture()
def disable_get_requests(monkeypatch):
    def disabled(*args, **kwargs):
        raise RuntimeError("requests disabled but HTTP GET attempted")
    from vunnel import utils
    monkeypatch.setattr(utils.http, "get", disabled)

and put into conftest.py generically for anyone to use

[wagoodman]

🙌