Add ability to create a clio.Application that runs test assertions instead of cmd.RunE #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
wagoodman
reviewed
Jan 26, 2024
wagoodman
reviewed
Jan 26, 2024
wagoodman
reviewed
Jan 26, 2024
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
The initializers may not be safe to run twice. Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
There are testutils packages everywhere. Rename clio's testutils package to cliotestutils so that it's more obvious what's being imported. Signed-off-by: Will Murphy <[email protected]>
This will be more readable when called as cliotestutils.NewApplication. Signed-off-by: Will Murphy <[email protected]>
willmurphyscode
changed the title
spiffcs
reviewed
Jan 29, 2024
| // env vars, and config files. Useful for testing that expected configuration options are wired up. | ||
| // Note that initializers will be cleared from the clio setup config, since the initialization may happen | ||
| // more than once and affect global state. For necessary global state, a workaround is to set it in a TestingMain. | ||
| func NewApplication(t *testing.T, cfg *clio.SetupConfig, assertions ...AssertionFunc) clio.Application { |
There was a problem hiding this comment.
I like the composition approach here - it might get tough to debug this, since the assertions can happen so far away from the thing they are asserting against, but I think that's a second order concern.
spiffcs
approved these changes
Jan 29, 2024
willmurphyscode
commented
Jan 30, 2024
kzantow
approved these changes
Jan 30, 2024
wagoodman
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request adding a method to write unit tests that assert on the result of setting up the config in fangs/clio.