Fix attest with --key #2551
Merged
Fix attest with --key #2551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Alex Goodman <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
Signed-off-by: Will Murphy <[email protected]>
spiffcs
reviewed
Jan 29, 2024
|
@spiffcs - that's correct - a go.work file was used locally to test this. Once anchore/clio#37 is merged, I'll update this PR. It just makes sense to review them together, since it would be hard to see how the assertion and test application would be used in the clio PR. |
Signed-off-by: Will Murphy <[email protected]>
wagoodman
approved these changes
Jan 31, 2024
GijsCalis
pushed a commit
to GijsCalis/syft
that referenced
this pull request
Feb 19, 2024
Fix passing "--key" to the attest command. Additionally, pull in an update to the clio CLI library to permit unit testing that flags and env vars are parsed to the correct field on command options structs. This testing strategy was needed here because testing attestation in an end to end test requires a prohibitive amount of setup. --------- Signed-off-by: Alex Goodman <[email protected]> Signed-off-by: Will Murphy <[email protected]> Co-authored-by: Alex Goodman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request adding a new testing pattern for CLIs, based on work over in clio: anchore/clio#37
Some feedback on this PR might inform anchore/clio#37, and this is meant to be merged after anchore/clio#37.
Fixes #2544 #2590
Testing
SYFT_ATTEST_PASSWORDenv var and--keyflag onattestsubcommand.SYFT_ATTEST_PASSWORD=<some-password> go run cmd/syft/main.go attest ghcr.io/willmurphyscode/test_image:latest --key ../scratch/empty/cosign.key)