Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: don't run e2e tests if deploy cancelled #625

Merged
merged 1 commit into from
Jan 4, 2025

Conversation

keyserj
Copy link
Collaborator

@keyserj keyserj commented Jan 4, 2025

status check only errors if build errors. if deploy is cancelled e.g. because only docs-site was changed, the status check succeeds with text including "cancelled".

discovered on #624

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for velvety-vacherin-4193fb ready!

Name Link
🔨 Latest commit 4bc72f3
🔍 Latest deploy log https://app.netlify.com/sites/velvety-vacherin-4193fb/deploys/67796635556f7700086c87e6
😎 Deploy Preview https://deploy-preview-625--velvety-vacherin-4193fb.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
1 paths audited
Performance: 84
Accessibility: 86
Best Practices: 92
SEO: 100
PWA: 80
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Copy link

netlify bot commented Jan 4, 2025

Deploy Preview for ameliorate-docs canceled.

Name Link
🔨 Latest commit 4bc72f3
🔍 Latest deploy log https://app.netlify.com/sites/ameliorate-docs/deploys/677966352ae2fb0008014e95

@keyserj keyserj force-pushed the fix-dont-run-e2e-tests-if-deploy-cancelled branch 2 times, most recently from 811dc99 to 3bb679b Compare January 4, 2025 16:20
status check only errors if build errors. if deploy is cancelled e.g.
because only docs-site was changed, the status check succeeds with text
including "cancelled".
@keyserj keyserj force-pushed the fix-dont-run-e2e-tests-if-deploy-cancelled branch 2 times, most recently from 4f1250a to 4bc72f3 Compare January 4, 2025 16:47
@keyserj keyserj merged commit 9cfd706 into main Jan 4, 2025
18 checks passed
@keyserj keyserj deleted the fix-dont-run-e2e-tests-if-deploy-cancelled branch January 4, 2025 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant