fix: don't run e2e tests if deploy cancelled

status check only errors if build errors. if deploy is cancelled e.g.
because only docs-site was changed, the status check succeeds with text
including "cancelled".

.github/workflows/ci.yml

@@ -52,30 +52,38 @@ jobs:
         with:
           token: ${{ secrets.GITHUB_TOKEN }}
           statusName: "netlify/velvety-vacherin-4193fb/deploy-preview"
-        # So that tests don't run if the preview failed
-      - name: Fail workflow if Preview Failed
+      # don't want to show e2e tests as passing if preview failed
+      - name: Fail if Preview didn't deploy
         if: steps.wait-for-status.outputs.state == 'failure'
         run: exit 1
       - name: Begin e2e setup - checkout
+        # If deploy was cancelled, wait-for-status.state is still considered succeeded, and we don't
+        # want to fail the e2e tests in this case, so we need to skip all the following steps.
+        # Unfortunately it seems that we need this `if` duplicated on all steps in order to do skip
+        # without failing https://github.com/orgs/community/discussions/27174
+        if: steps.wait-for-status.outputs.description == 'Deploy Preview ready!'
         uses: actions/checkout@v3
       - uses: actions/setup-node@v3
+        if: steps.wait-for-status.outputs.description == 'Deploy Preview ready!'
         with:
           node-version-file: e2e/.nvmrc
       - name: Install dependencies
+        if: steps.wait-for-status.outputs.description == 'Deploy Preview ready!'
         run: npm ci
       # assume that if snapshots fail, that we want to update & commit them (to be reviewed in the PR)
       - run: npm run update-snapshots
+        if: steps.wait-for-status.outputs.description == 'Deploy Preview ready!'
         env:
           DEPLOY_PRIME_URL: ${{  steps.wait-for-status.outputs.target_url }}
       - uses: stefanzweifel/git-auto-commit-action@v5
-        if: ${{ !cancelled() }}
+        if: steps.wait-for-status.outputs.description == 'Deploy Preview ready!' && ${{ !cancelled() }}
         with:
           # skip ci in commit message to prevent triggering GHA or Netlify, since we can trust the previous triggers
           commit_message: "chore: automated snapshot updates [skip ci]"
           file_pattern: "e2e/**/*-snapshots/*.png"
       # tests can still fail for non-snapshot assertions - keep the test-report around in this case
       - uses: actions/upload-artifact@v4
-        if: ${{ !cancelled() }}
+        if: steps.wait-for-status.outputs.description == 'Deploy Preview ready!' && ${{ !cancelled() }}
         with:
           name: playwright-report
           # `uses` isn't affected by the `defaults.run.working-directory`, so we still need to prepend `e2e` https://stackoverflow.com/a/63122434/8409296