Remove TODOs

amazon-contributing · Jan 8, 2025 · 2daedb1 · 2daedb1
1 parent 2bd8446
commit 2daedb1
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 3 deletions.
diff --git a/exporter/awsemfexporter/emf_exporter.go b/exporter/awsemfexporter/emf_exporter.go
@@ -77,7 +77,6 @@ func newEmfExporter(config *Config, set exporter.Settings) (*emfExporter, error)
 		processResourceLabels: func(map[string]string) {},
 	}
 
-	// TODO(kausyas): Check why this isnt in upstream
 	if config.IsAppSignalsEnabled() {
 		userAgent := appsignals.NewUserAgent()
 		emfExporter.processResourceLabels = userAgent.Process
@@ -104,7 +103,7 @@ func (emf *emfExporter) pushMetricsData(_ context.Context, md pmetric.Metrics) e
 		}
 	}
 	emf.config.logger.Debug("Start processing resource metrics", zap.Any("labels", labels))
-	emf.processResourceLabels(labels) // TODO(kausyas): Check why this isnt in upstream
+	emf.processResourceLabels(labels)
 
 	groupedMetrics := make(map[any]*groupedMetric)
 	defaultLogStream := fmt.Sprintf("otel-stream-%s", emf.collectorID)

diff --git a/receiver/awscontainerinsightreceiver/internal/cadvisor/extractors/extractor_test.go b/receiver/awscontainerinsightreceiver/internal/cadvisor/extractors/extractor_test.go
@@ -60,7 +60,6 @@ func TestGetMetricKey(t *testing.T) {
 			ci.ContainerNamekey: "containerName",
 		},
 	}
-	// TODO(kausyas): Make sure this isnt exported anywhere
 	assert.Equal(t, "metricType:Container,podId:podID,containerName:containerName", getMetricKey(c))
 
 	c = &stores.CIMetricImpl{