Skip to content

Commit

Permalink
Address findings from initial code review
Browse files Browse the repository at this point in the history
  • Loading branch information
dricross committed Jan 7, 2025
1 parent 4c908c1 commit 2bd8446
Show file tree
Hide file tree
Showing 3 changed files with 2 additions and 2 deletions.
1 change: 1 addition & 0 deletions internal/aws/containerinsight/utils_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -96,6 +96,7 @@ func TestIsContainer(t *testing.T) {
assert.True(t, IsContainer(TypeContainerEFA))
assert.True(t, IsContainer(TypeContainerGPU))
assert.True(t, IsContainer(TypeContainerFS))
assert.False(t, IsContainer(TypePod))
}

func TestIsPod(t *testing.T) {
Expand Down
1 change: 0 additions & 1 deletion internal/aws/proxy/server.go
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,6 @@ type Server interface {
func NewServer(cfg *Config, logger *zap.Logger) (Server, error) {
_, err := net.ResolveTCPAddr("tcp", cfg.Endpoint)
if err != nil {
fmt.Printf("aeraesra")
return nil, err
}
if cfg.ProxyAddress != "" {
Expand Down
2 changes: 1 addition & 1 deletion receiver/awscontainerinsightskueuereceiver/receiver.go
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ import (
"k8s.io/client-go/rest"

ci "github.com/open-telemetry/opentelemetry-collector-contrib/internal/aws/containerinsight"
kueuescraper "github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awscontainerinsightskueuereceiver/internal/kueuescraper"
"github.com/open-telemetry/opentelemetry-collector-contrib/receiver/awscontainerinsightskueuereceiver/internal/kueuescraper"
)

var _ receiver.Metrics = (*awsContainerInsightKueueReceiver)(nil)
Expand Down

0 comments on commit 2bd8446

Please sign in to comment.