test: invariant basic properties #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Comment on lines
220
to
225
| bool _isManager; | ||
| for (uint256 _i; _i < ghost_poolManagers[_poolId].length; _i++) { | ||
| if (msg.sender == ghost_poolManagers[_poolId][_i]) { | ||
| _isManager = true; | ||
| break; | ||
| } |
There was a problem hiding this comment.
shouldn't this be tidier as a function (ideally have it on the address type, so you could just use if(msg.sender.isManager() ...)?
| // Get the profile ID | ||
| IRegistry.Profile memory _profile = registry.getProfileByAnchor(_ghost_anchorOf[msg.sender]); | ||
|
|
||
| address[] memory _members = new address[](1); | ||
| address _newMember = _ghost_actors[_actorSeed % (_ghost_actors.length - 1)]; |
There was a problem hiding this comment.
this should be an helper in actors, pickActor(seed) or smth
Signed-off-by: 0xRaccoon <[email protected]>
… into test/invariant-basic-properties Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
Signed-off-by: 0xRaccoon <[email protected]>
| @@ -224,7 +230,7 @@ contract HandlerAllo is Setup { | |||
| function _pickPoolId(uint256 _idSeed) internal view returns (uint256) { | |||
| if (ghost_poolIds.length == 0) return 0; | |||
|
|
|||
| return ghost_poolIds[_idSeed % ghost_poolIds.length]; | |||
| return ghost_poolIds[_idSeed % ghost_poolIds.length - 1]; | |||
There was a problem hiding this comment.
the -1 seems incorrect to me. idSeed starts at 0, meaning seed % length starts at 0 too (and goes up to length - 1 when seed = length-1 (when seed = length, then length%length is back to the indice 0 of the array)
There was a problem hiding this comment.
it's not reverting due to the underflow during the test as it's outside of an assert, but leave the last element of the array untouched
| @@ -117,4 +117,8 @@ contract Actors is Utils { | |||
| function _removeAnchorFromActor(address _actor, bytes32 _profileId) internal { | |||
| delete _ghost_anchorOf[_actor]; | |||
| } | |||
|
|
|||
| function _pickActor(uint256 _seed) internal view returns (address _actor) { | |||
| _actor = _ghost_actors[_seed % (_ghost_actors.length - 1)]; | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.