test: invariant basic properties

test/invariant/PROPERTIES.md

@@ -8,17 +8,17 @@
 | 2   | a token allocation never “disappears” (withdraw cannot impact an allocation)                                      | []      |
 | 3   | an address can only withdraw if has allocation                                                                    | []      |
 | 4   | profile owner can always create a pool                                                                            | []      |
-| 5   | profile owner is the only one who can always add/remove/modify profile members (name ⇒ new anchor())              | []      |
-| 6   | profile owner is the only one who can always initiate a change of profile owner (2 steps)                         | []      |
+| 5   | profile owner is the only one who can always add/remove/modify profile members (name ⇒ new anchor())              | [x]      |
+| 6   | profile owner is the only one who can always initiate a change of profile owner (2 steps)                         | [x]      |
 | 7   | profile member can always create a pool                                                                           | []      |
 | 8   | only profile owner or member can create a pool                                                                    | []      |
 | 9   | initial admin is always the creator of the pool                                                                   | []      |
-| 10  | pool admin can always change admin (but not to address(0))                                                        | []      |
-| 11  | pool admin can always add/remove pool managers                                                                    | []      |
+| 10  | pool admin can always change admin (but not to address(0))                                                        | [x]      |
+| 11  | pool admin can always add/remove pool managers                                                                    | [x]      |
 | 12  | pool manager can always withdraw within strategy limits/logic                                                     | []      |
-| 13  | pool manager can always change metadata                                                                           | []      |
-| 14  | allo owner can always change base fee (flat) and percent flee (./. funding amt) to any arbitrary value (max 100%) | []      |
-| 15  | allo owner can always change the treasury address/trustred forwarded/etc                                          | []      |
+| 13  | pool manager can always change metadata                                                                           | [x]      |
+| 14  | allo owner can always change base fee (flat) and percent flee (./. funding amt) to any arbitrary value (max 100%) | [x]      |
+| 15  | allo owner can always change the treasury address/trustred forwarded/etc                                          | [x]      |
 | 16  | allo owner can always recover funds from allo contract ( (non-)native token )                                     | []      |
 | 17  | only funds not allocated can be withdrawn                                                                         | []      |
 | 18  | anyone can increase fund in a pool, if strategy (hook) logic allows so and if more than base fee                  | []      |

test/invariant/fuzz/Setup.t.sol

@@ -49,24 +49,13 @@ contract Setup is Actors, Pools {
         registry = new Registry();
 
         // Deploy the proxy, pointing to the implementation
-        TransparentUpgradeableProxy proxy = new TransparentUpgradeableProxy(
-            implementation,
-            proxyOwner,
-            ""
-        );
+        TransparentUpgradeableProxy proxy = new TransparentUpgradeableProxy(implementation, proxyOwner, "");
 
         allo = Allo(payable(address(proxy)));
 
         // Initialize
         vm.prank(protocolDeployer);
-        allo.initialize(
-            protocolDeployer,
-            address(registry),
-            payable(treasury),
-            percentFee,
-            baseFee,
-            forwarder
-        );
+        allo.initialize(protocolDeployer, address(registry), payable(treasury), percentFee, baseFee, forwarder);
 
         // Deploy strategies implementations
         _initImplementations(address(allo));
@@ -75,19 +64,12 @@ contract Setup is Actors, Pools {
         token = ERC20(address(new FuzzERC20()));
 
         // Create profile for 4 addresses
-        for (uint i; i < 4; i++) {
+        for (uint256 i; i < 4; i++) {
             bytes32 _id = registry.createProfile(
-                0,
-                "a",
-                Metadata({protocol: i + 1, pointer: ""}),
-                _ghost_actors[i],
-                new address[](0)
+                0, "a", Metadata({protocol: i + 1, pointer: ""}), _ghost_actors[i], new address[](0)
             );
 
-            _addAnchorToActor(
-                _ghost_actors[i],
-                registry.getProfileById(_id).anchor
-            );
+            _addAnchorToActor(_ghost_actors[i], registry.getProfileById(_id).anchor, _id);
         }
 
         // Create pools for each strategy
@@ -105,9 +87,7 @@ contract Setup is Actors, Pools {
         for (uint256 i = 1; i <= uint256(type(PoolStrategies).max); i++) {
             address _deployer = _ghost_actors[i % 4];
 
-            IRegistry.Profile memory profile = registry.getProfileByAnchor(
-                _ghost_anchorOf[_deployer]
-            );
+            IRegistry.Profile memory profile = registry.getProfileByAnchor(_ghost_anchorOf[_deployer]);
 
             bytes memory _metadata;
 
@@ -126,9 +106,9 @@ contract Setup is Actors, Pools {
                     token,
                     true
                 );
-            } else if (
-                PoolStrategies(i) == PoolStrategies.EasyRPGF
-            ) {} else if (PoolStrategies(i) == PoolStrategies.ImpactStream) {
+            } else if (PoolStrategies(i) == PoolStrategies.EasyRPGF) {} else if (
+                PoolStrategies(i) == PoolStrategies.ImpactStream
+            ) {
                 _metadata = abi.encode(
                     IRecipientsExtension.RecipientInitializeData({
                         metadataRequired: false,
@@ -182,6 +162,7 @@ contract Setup is Actors, Pools {
             );
 
             ghost_poolAdmins[_poolId] = _deployer;
+            assertTrue(allo.isPoolAdmin(_poolId, _deployer), "Admin not set _initPools_");
 
             _recordPool(_poolId, PoolStrategies(i));
         }