Don't run OS initialization during elaboration #1592
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As this makes impossible to tweak such initialization with `alr config`.
mosteo
commented
Feb 26, 2024
Comment on lines
-33
to
-44
| declare | ||
| Unused : Vector; | ||
| begin | ||
| Unused := OS_Lib.Subprocess.Checked_Spawn_And_Capture | ||
| ("pacman", Empty_Vector & ("-V"), | ||
| Err_To_Out => True); | ||
| return True; | ||
| exception when others => | ||
| null; | ||
| end; | ||
|
|
||
| return False; |
There was a problem hiding this comment.
This caused unintended stderr output when no pacman was found in path
Fabien-Chouteau
approved these changes
Feb 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As this makes impossible to tweak such initialization with
alr config.More precisely, it was now impossible to disable installation of msys2 via
alr config --set msys2.do_not_install.With this PR, msys2 installation is not run unconditionally during elaboration, but later on when we are sure the user is not running
alr config(oralr --version)For good measure, also check that unexpected msys2 installation is not attempted during test runs.