Make msys live inside overridden config path by default #1589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mosteo
force-pushed
the
fix/msys-path
branch
5 times, most recently
from
2ff58d7 to
3749678
Compare
mosteo
force-pushed
the
fix/msys-path
branch
from
3749678 to
ee02d5e
Compare
As this makes impossible to tweak such initialization with `alr config`.
mosteo
force-pushed
the
fix/msys-path
branch
from
ee02d5e to
2231163
Compare
mosteo
force-pushed
the
fix/msys-path
branch
from
8ed0842 to
3faf720
Compare
Fabien-Chouteau
approved these changes
Feb 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goes on top of #1592
This is just a matter of defaults, as this path can be set with
alr config --set msys2.install_dir <path>anyway.The current intent is that overriding
ALR_CONFIGgives you an entirely isolated configuration. So when that variable is set, the default cache location is also moved insideALR_CONFIG.Except that, right now,
msys2isn't honoring this, as it is using the default cache location even ifALR_CONFIGis set. This PR brings in line the installation dir ofmsys2to honor other cache uses that are indeed relocated.