Skip to content

Commit

Permalink
Merge pull request #2558 from alicevision/fix/unknownNodeTemplate
Browse files Browse the repository at this point in the history
[core] Node: Do not automatically upgrade unknown nodes in templates
  • Loading branch information
fabiencastan authored Oct 16, 2024
2 parents 9d6fdf1 + ff8c063 commit ea92b72
Showing 1 changed file with 3 additions and 1 deletion.
4 changes: 3 additions & 1 deletion meshroom/core/node.py
Original file line number Diff line number Diff line change
Expand Up @@ -1922,7 +1922,9 @@ def nodeFactory(nodeDict, name=None, template=False, uidConflict=False):
if not internalFolder and nodeDesc:
logging.warning("No serialized output data: performing automatic upgrade on '{}'".format(name))
node = node.upgrade()
elif template: # If the node comes from a template file and there is a conflict, it should be upgraded anyway
# If the node comes from a template file and there is a conflict, it should be upgraded anyway unless it is
# an "unknown node type" conflict (in which case the upgrade would fail)
elif template and compatibilityIssue is not CompatibilityIssue.UnknownNodeType:
node = node.upgrade()

return node

0 comments on commit ea92b72

Please sign in to comment.