Merge pull request #2563 from alicevision/fix/minorUiFixes

[ui] Various minor UI fixes
alicevision · Oct 16, 2024 · 9d6fdf1 · 9d6fdf1
2 parents 1fbdafe + 12249de
commit 9d6fdf1
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 20 deletions.
diff --git a/meshroom/nodes/aliceVision/Publish.py b/meshroom/nodes/aliceVision/Publish.py
@@ -28,6 +28,7 @@ class Publish(desc.Node):
             name="inputFiles",
             label="Input Files",
             description="Input files or folders' content to publish.",
+            exposed=True,
             group="",
         ),
         desc.File(

diff --git a/meshroom/ui/qml/GraphEditor/AttributePin.qml b/meshroom/ui/qml/GraphEditor/AttributePin.qml
@@ -236,7 +236,8 @@ RowLayout {
             anchors.fill: parent
             anchors.margins: 2
             color: {
-                if ((!object.hasOutputConnections && object.enabled) && outputConnectMA.containsMouse || outputConnectMA.drag.active || (outputDropArea.containsDrag && outputDropArea.acceptableDrop))
+                if (object.enabled && (outputConnectMA.containsMouse || outputConnectMA.drag.active ||
+                                       (outputDropArea.containsDrag && outputDropArea.acceptableDrop)))
                     return Colors.sysPalette.highlight
                 return Colors.sysPalette.text
             }

diff --git a/meshroom/ui/qml/GraphEditor/GraphEditor.qml b/meshroom/ui/qml/GraphEditor/GraphEditor.qml
@@ -521,22 +521,6 @@ Item {
                             }
                         }
                     }
-                    onVisibleChanged: {
-                        if (visible) {
-                            // Enable the pins on both sides
-                            src.updatePin(true, true)  // isSrc = true, isVisible = true
-                            dst.updatePin(false, true)  // isSrc = false, isVisible = true
-                        } else {
-                            // One of the attributes is visible, we do not need to handle the case where both attributes are hidden
-                            if (isValidEdge && (src.visible || dst.visible)) {
-                                if (src.visible) {
-                                    src.updatePin(true, false)  // isSrc = true, isVisible = false
-                                } else {
-                                    dst.updatePin(false, false)  // isSrc = false, isVisible = false
-                                }
-                            }
-                        }
-                    }
 
                     Component.onDestruction: {
                         // Handles the case where the edge is destroyed while hidden because it is replaced: the pins should be re-enabled

diff --git a/meshroom/ui/qml/Homepage.qml b/meshroom/ui/qml/Homepage.qml
@@ -22,7 +22,7 @@ Page {
 
         Item {
 
-            SplitView.minimumWidth: 100
+            SplitView.minimumWidth: 250
             SplitView.preferredWidth: 330
             SplitView.maximumWidth: 500
 

diff --git a/meshroom/ui/qml/Viewer/SequencePlayer.qml b/meshroom/ui/qml/Viewer/SequencePlayer.qml
@@ -385,7 +385,7 @@ FloatingPane {
                                 verticalAlignment: Text.AlignVCenter
                                 text: {
                                     // number of cached frames is the difference between the first and last frame of all intervals in the cache
-                                    let cachedFrames = viewer.cachedFrames
+                                    let cachedFrames = viewer ? viewer.cachedFrames : []
                                     let cachedFramesCount = 0
                                     for (let i = 0; i < cachedFrames.length; i++) {
                                         cachedFramesCount += cachedFrames[i].y - cachedFrames[i].x + 1
@@ -420,7 +420,7 @@ FloatingPane {
                             ProgressBar {
                                 id: occupiedCacheProgressBar
 
-                                property string occupiedCache: viewer.ramInfo ? Format.GB2SizeStr(viewer.ramInfo.y) : 0
+                                property string occupiedCache: viewer && viewer.ramInfo ? Format.GB2SizeStr(viewer.ramInfo.y) : 0
 
                                 width: parent.width