Enable per-monitor copy settings #20
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex-courtis
requested changes
Jun 7, 2022
| int xpos = 0; | ||
| int ypos = 0; | ||
| for (const auto &output : outputs) { | ||
|
|
||
| if (output->desiredActive) { | ||
| if (output->desiredActive && copies.find(output->name) == copies.end()) { |
There was a problem hiding this comment.
We need to test whether the destination (and source) exists. xlayoutdisplay --copy HDMI1:aoeu results in HDMI1 being disabled.
A good place might be after discoverOutputs, with an error/exit message like "copy src HDMI2222 not found"
| @@ -57,6 +57,7 @@ void usage(std::ostream &os) { | |||
| "-r [ --rate ] arg Refresh rate override\n" | |||
| "-m [ --mirror ] mirror outputs using the lowest common resolution\n" | |||
| "-o [ --order ] arg order of outputs, repeat as needed\n" | |||
| "-c [ --copy ] arg arg in format dst:src, copy from output src to output dst, repeat as needed\n" | |||
There was a problem hiding this comment.
Perhaps "copy resolution, refresh and position using format dst:src, repeat as needed"
|
|
||
| if (output->desiredActive && target->desiredActive) { | ||
|
|
||
| // find supported mode of output that has same size of target |
There was a problem hiding this comment.
I like the fallback to highest available.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables
-cflag, which will allow user to specify per-monitor display copying.