Enable option to read config from specific file #21
Conversation
| @@ -126,6 +128,12 @@ void parseArgs(int argc, char **argv, Settings &settings) { | |||
| case 'i': | |||
| settings.info = true; | |||
| break; | |||
| case 'f': | |||
| { | |||
| ifstream ifs(optarg); | |||
There was a problem hiding this comment.
Please test ifs and error/exit if not found.
Something simple like "config file /path/to/.xlayoutdisplay not found, exiting"
| @@ -126,6 +128,12 @@ void parseArgs(int argc, char **argv, Settings &settings) { | |||
| case 'i': | |||
| settings.info = true; | |||
| break; | |||
| case 'f': | |||
| { | |||
| ifstream ifs(optarg); | |||
There was a problem hiding this comment.
Please test ifs and error/exit if not found.
Something simple like "config file /path/to/.xlayoutdisplay not found, exiting"
| case 'f': | ||
| { | ||
| ifstream ifs(optarg); | ||
| parseCfgFile(ifs, settings); |
There was a problem hiding this comment.
Settings from the default config files will be present. Any settings from the defaults that are not present in this file will still remain in the settings. Also, depending on invocation order, command line arguments may be overridden by the settings file.
Possible solutions:
- destroy existing settings before reading -f
- do not read default files when -f
- read file and CLI settings separately then merge them
First two would require a "two pass" approach to reading arguments, the first lookng for -f and reading it prior to parsing the rest of the command line arguments.
|
I'll merge this one after #20 |
Enable
-foption for user to specify a file as the config to read from